Allow passing int for uint spec when int precision > uint precision #298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #294.
Previously, when the
ObjectMapper
receives an int64 value for a uint32 spec, HDMF would raise an error. An int64 for a uint64, however, worked. The error was only raised if the given int value's precision was higher than the spec uint's precision.With this change:
A warning will also be raised when the given base type differs from the specified type, such that a conversion occurs, e.g., a float32 value is given for an int32 spec. This was previously converted invisibly.