Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge support for python 2 to clean up code, remove six dependency #213

Merged
merged 6 commits into from
Dec 18, 2019

Conversation

rly
Copy link
Contributor

@rly rly commented Nov 27, 2019

This PR is not high priority by any means, but since I had started refactoring, I might as well finish the job. To clean up the code and remove the dependency on the six package, I purged all uses of six, e.g., text_type, binary_type, string_types, integer_types, raise_from, with_metaclass, etc.

Also:

  • removed any imports of future
  • updated .gitignore to use absolute paths which prevents my code editor from ignoring the src/hdmf/build/ directory.
  • use python 3 style classes (implicit inheritance from object) and super()

@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #213 into dev will decrease coverage by 0.07%.
The diff coverage is 73.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #213      +/-   ##
==========================================
- Coverage   70.46%   70.38%   -0.08%     
==========================================
  Files          31       31              
  Lines        5935     5920      -15     
  Branches     1390     1389       -1     
==========================================
- Hits         4182     4167      -15     
  Misses       1322     1322              
  Partials      431      431
Impacted Files Coverage Δ
src/hdmf/monitor.py 0% <0%> (ø) ⬆️
src/hdmf/spec/write.py 77.85% <100%> (-0.16%) ⬇️
src/hdmf/query.py 57.27% <100%> (-0.39%) ⬇️
src/hdmf/common/io/table.py 55.55% <100%> (ø) ⬆️
src/hdmf/utils.py 92.21% <100%> (ø) ⬆️
src/hdmf/backends/io.py 96.77% <100%> (-0.11%) ⬇️
src/hdmf/array.py 51.85% <100%> (-0.36%) ⬇️
src/hdmf/spec/catalog.py 92.07% <100%> (ø) ⬆️
src/hdmf/data_utils.py 90.74% <100%> (-0.07%) ⬇️
src/hdmf/container.py 68.36% <100%> (-0.12%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a01604...cb4934a. Read the comment docs.

@rly rly requested a review from ajtritt December 18, 2019 20:40
@rly
Copy link
Contributor Author

rly commented Dec 18, 2019

@ajtritt can we merge this? this will make the diff for my dimension scales PR significantly easier to follow. thanks

@rly rly merged commit 448b467 into dev Dec 18, 2019
@rly rly deleted the purge_py2_support branch December 18, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants