Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/register container #175

Merged
merged 5 commits into from
Oct 17, 2019
Merged

Bug/register container #175

merged 5 commits into from
Oct 17, 2019

Conversation

ajtritt
Copy link
Contributor

@ajtritt ajtritt commented Oct 17, 2019

Motivation

hdmf.data_utils.get_shape always infers shape on its own. Use specified shape if it is there.

This is needed to fix NeurodataWithoutBorders/pynwb#1082

@ajtritt ajtritt requested review from rly, bendichter and oruebel October 17, 2019 00:59
@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #175 into dev will increase coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #175      +/-   ##
=========================================
+ Coverage   70.3%   70.32%   +0.01%     
=========================================
  Files         30       30              
  Lines       5823     5830       +7     
  Branches    1370     1371       +1     
=========================================
+ Hits        4094     4100       +6     
- Misses      1298     1299       +1     
  Partials     431      431
Impacted Files Coverage Δ
src/hdmf/data_utils.py 90% <100%> (+0.06%) ⬆️
src/hdmf/common/__init__.py 70.11% <100%> (+1.06%) ⬆️
src/hdmf/backends/hdf5/h5_utils.py 63.76% <50%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a115dc6...ac53149. Read the comment docs.

@ajtritt ajtritt merged commit 56ebfc3 into dev Oct 17, 2019
@rly rly deleted the bug/register_container branch January 7, 2020 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual NWB file validation fails
2 participants