Skip to content

Commit

Permalink
Remove unnecessary testing on conda
Browse files Browse the repository at this point in the history
  • Loading branch information
rly committed Jan 14, 2025
1 parent 42aab62 commit dfbe38c
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 136 deletions.
10 changes: 1 addition & 9 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,6 @@ body:
- Linux
validations:
required: true
- type: dropdown
id: executable
attributes:
label: Python Executable
options:
- Conda
- Python
validations:
required: true
- type: dropdown
id: python_version
attributes:
Expand All @@ -65,6 +56,7 @@ body:
- "3.11"
- "3.10"
- "3.9"
- "other"
validations:
required: true
- type: textarea
Expand Down
64 changes: 0 additions & 64 deletions .github/workflows/run_all_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -126,70 +126,6 @@ jobs:
run: |
tox -e ${{ matrix.test-tox-env }}
run-all-tests-on-conda:
name: ${{ matrix.name }}
runs-on: ubuntu-latest
defaults:
run:
shell: bash -l {0} # needed for conda environment to work
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.name }}
cancel-in-progress: true
strategy:
fail-fast: false
matrix:
include:
- { name: conda-linux-python3.9-minimum , test-tox-env: pytest-py39-minimum , python-ver: "3.9" , os: ubuntu-latest }
- { name: conda-linux-python3.10-upgraded , test-tox-env: pytest-py310-upgraded , python-ver: "3.10", os: ubuntu-latest }
- { name: conda-linux-python3.11-upgraded , test-tox-env: pytest-py311-upgraded , python-ver: "3.11", os: ubuntu-latest }
- { name: conda-linux-python3.12-upgraded , test-tox-env: pytest-py312-upgraded , python-ver: "3.12", os: ubuntu-latest }
- { name: conda-linux-python3.13-upgraded , test-tox-env: pytest-py313-upgraded , python-ver: "3.13", os: ubuntu-latest }
- { name: conda-linux-python3.13-upgraded-optional , test-tox-env: pytest-py313-upgraded-optional , python-ver: "3.13", os: ubuntu-latest }
- { name: conda-linux-python3.13-prerelease-optional , test-tox-env: pytest-py313-prerelease-optional , python-ver: "3.13", os: ubuntu-latest }
steps:
- name: Checkout repo with submodules
uses: actions/checkout@v4
with:
submodules: 'recursive'
fetch-depth: 0 # tags are required to determine the version

- name: Set up Conda
uses: conda-incubator/setup-miniconda@v3
with:
auto-update-conda: true
python-version: ${{ matrix.python-ver }}
channels: conda-forge

- name: Install build dependencies
run: |
conda config --set always_yes yes --set changeps1 no
conda info
conda install -c conda-forge "tox>=4"
- name: Conda reporting
run: |
conda info
conda config --show-sources
conda list --show-channel-urls
# NOTE tox installs packages from PyPI not conda-forge...
- name: Run tox tests
run: |
tox -e ${{ matrix.test-tox-env }}
- name: Build wheel and source distribution
run: |
tox -e build
ls -1 dist
- name: Test installation from a wheel
run: |
tox -e wheelinstall --installpkg dist/*-none-any.whl
- name: Test installation from a source distribution
run: |
tox -e wheelinstall --installpkg dist/*.tar.gz
run-ros3-tests:
name: ${{ matrix.name }}
runs-on: ${{ matrix.os }}
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/run_coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,13 @@ jobs:
- name: Install package
if: ${{ ! matrix.opt_req }}
run: python -m pip install ".[test]"
run: |
python -m pip install ".[test]"
- name: Install package with optional dependencies
if: ${{ matrix.opt_req }}
run: python -m pip install ".[test,full]"
run: |
python -m pip install ".[test,full]"
- name: Run tests and generate coverage report
run: |
Expand Down
62 changes: 1 addition & 61 deletions .github/workflows/run_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,69 +112,9 @@ jobs:
run: |
tox -e ${{ matrix.test-tox-env }}
run-tests-on-conda:
name: ${{ matrix.name }}
runs-on: ubuntu-latest
defaults:
run:
shell: bash -l {0}
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.name }}
cancel-in-progress: true
strategy:
fail-fast: false
matrix:
include:
- { name: conda-linux-python3.9-minimum , test-tox-env: pytest-py39-minimum , python-ver: "3.9" , os: ubuntu-latest }
- { name: conda-linux-python3.13-upgraded , test-tox-env: pytest-py313-upgraded , python-ver: "3.13", os: ubuntu-latest }
- { name: conda-linux-python3.13-upgraded-optional , test-tox-env: pytest-py313-upgraded-optional , python-ver: "3.13", os: ubuntu-latest }
steps:
- name: Checkout repo with submodules
uses: actions/checkout@v4
with:
submodules: 'recursive'
fetch-depth: 0 # tags are required to determine the version

- name: Set up Conda
uses: conda-incubator/setup-miniconda@v3
with:
auto-update-conda: true
python-version: ${{ matrix.python-ver }}
channels: conda-forge

- name: Install build dependencies
run: |
conda config --set always_yes yes --set changeps1 no
conda info
conda install -c conda-forge "tox>=4"
- name: Conda reporting
run: |
conda info
conda config --show-sources
conda list --show-channel-urls
# NOTE tox installs packages from PyPI not conda-forge...
- name: Run tox tests
run: |
tox -e ${{ matrix.test-tox-env }}
- name: Build wheel and source distribution
run: |
tox -e build
ls -1 dist
- name: Test installation from a wheel
run: |
tox -e wheelinstall --installpkg dist/*-none-any.whl
- name: Test installation from a source distribution
run: |
tox -e wheelinstall --installpkg dist/*.tar.gz
deploy-dev:
name: Deploy pre-release from dev
needs: [run-tests, run-gallery-tests, run-tests-on-conda]
needs: [run-tests, run-gallery-tests]
if: ${{ github.event_name == 'push' }}
runs-on: ubuntu-latest
concurrency:
Expand Down

0 comments on commit dfbe38c

Please sign in to comment.