Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add best practices section, prepare 3.0.0 release #32

Merged
merged 11 commits into from
Jan 19, 2025
Merged

Add best practices section, prepare 3.0.0 release #32

merged 11 commits into from
Jan 19, 2025

Conversation

rly
Copy link
Contributor

@rly rly commented Apr 10, 2024

Fix #14

@rly rly requested a review from oruebel April 10, 2024 20:34
@rly rly requested review from oruebel and removed request for oruebel August 9, 2024 17:31
@rly rly added this to the 3.0.0 milestone Aug 9, 2024
Comment on lines 31 to 32
7. Non-scalar values for the ``value`` and ``default_value`` keys are not fully supported in the official APIs,
so these are discouraged until support is added.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify this a bit more. E.g., does this include arrays/lists, strings etc. Maybe provide an example of common types that one would want to use that are not supported yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I clarified it

source/best_practices.rst Outdated Show resolved Hide resolved
source/best_practices.rst Outdated Show resolved Hide resolved
source/best_practices.rst Outdated Show resolved Hide resolved
@rly rly requested a review from oruebel January 18, 2025 07:45
source/best_practices.rst Outdated Show resolved Hide resolved
@rly rly merged commit ae24617 into main Jan 19, 2025
1 check passed
@rly rly deleted the best_practices branch January 19, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add best practices section
2 participants