Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmark tests #5

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Add benchmark tests #5

merged 1 commit into from
Oct 27, 2020

Conversation

kohrapha
Copy link
Collaborator

Add benchmarks to track package performance and compare across changes.

@kohrapha kohrapha requested a review from hdj630 October 20, 2020 18:48
@kohrapha kohrapha self-assigned this Oct 20, 2020
@kohrapha
Copy link
Collaborator Author

Tagging @mxiamxia for review. Not able to add you as a reviewer 🤔

@kohrapha
Copy link
Collaborator Author

Additionally, should we create a bench.txt file that tracks the most up-to-date benchmark that we can use to compare against for future code changes?

Then to compare, we just need to run benchcmp or benchstat to see the different in performance.

@kohrapha kohrapha mentioned this pull request Oct 20, 2020
Merged
mxiamxia
mxiamxia approved these changes Oct 27, 2020
View reviewed changes
Copy link

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this should also go to upstream. nice work

@kohrapha
Copy link
Collaborator Author

kohrapha commented Oct 27, 2020 •
edited
Loading

@mxiamxia thanks! Should this go into upstream as-is or should we add benchmarking files (like bench.txt) to track performance? Here's more info of what it would look like: https://godoc.org/golang.org/x/tools/cmd/benchcmp

@kohrapha
Copy link
Collaborator Author

I'll merge this in for now, and if we need a benchmarking file, we can open a new CR for that in the future.

@kohrapha kohrapha merged commit b060998 into master Oct 27, 2020
@kohrapha kohrapha deleted the kohrapha/benchmarks branch October 27, 2020 19:46
kohrapha added a commit that referenced this pull request Oct 28, 2020
@kohrapha
Add benchmark tests (#5)
237d7fc
kohrapha added a commit that referenced this pull request Oct 29, 2020
@kohrapha
Add benchmark tests (#5)
57007b1
kohrapha added a commit that referenced this pull request Oct 30, 2020
@kohrapha
Add benchmark tests (#5) (#1399)
7b6806f 
This CR adds benchmarking tests for the AWS EMF Exporter.

Testing:
The new benchmarking tests were run locally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxiamxia mxiamxia mxiamxia approved these changes

@hdj630 hdj630 Awaiting requested review from hdj630

Assignees

@kohrapha kohrapha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kohrapha @mxiamxia