Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boost installation script #1257

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Fix boost installation script #1257

merged 2 commits into from
Feb 19, 2025

Conversation

JackPGreen
Copy link
Contributor

@JackPGreen JackPGreen commented Feb 10, 2025

The coverage action is failing because the boost installation mirror is dead.

Changes:

  • update installation link to use boost archive
  • refactored script
    • use long-form command names
    • fix shellcheck warnings
    • avoid writing temporary download files to disk

Example action showing boost installation success.

The [coverage action is failing](https://github.com/hazelcast/hazelcast-cpp-client/actions/runs/13248710933/job/36981292995) because the `boost` installation mirror [is dead](https://landing.jfrog.com/reactivate-server/boostorg).

Changes:
- update installation link to use `boost` archive
- refactored script
   - use long-form command names
   - fix shellcheck warnings
   - avoid writing temporary download files to disk
@JackPGreen JackPGreen self-assigned this Feb 10, 2025
@JackPGreen JackPGreen marked this pull request as ready for review February 10, 2025 19:49
@JackPGreen JackPGreen enabled auto-merge (squash) February 10, 2025 19:49
@JackPGreen JackPGreen disabled auto-merge February 19, 2025 14:01
@JackPGreen JackPGreen merged commit 69f4306 into master Feb 19, 2025
28 of 45 checks passed
JackPGreen added a commit to JackPGreen/hazelcast-cpp-client that referenced this pull request Feb 20, 2025
Roll out the fix in hazelcast#1257 to other places the same error exists.

Fixes [build failures](https://github.com/hazelcast/hazelcast-cpp-client/actions/runs/13434648446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants