Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unmarshalling error when IP Allowlist is configured on viridian #339

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

pmcgleenon
Copy link
Contributor

Here's the log message from clc viridian list-clusters when a cluster has an IP Allow list configured

2023-08-11T19:47:32.962+0100    ERROR   viridian/common.go:228  listing clusters: json: cannot unmarshal array into Go struct field Cluster.Content.allowedIps of type string

Here's an example of what the IP looks like from the Viridian /cluster/ endpoint - grabbed from the Viridian UI
{id: 177, ip: "207.154.227.247", description: null}

@devOpsHazelcast
Copy link

devOpsHazelcast commented Aug 11, 2023

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for eclectic-sawine-19fcf1 canceled.

Name Link
🔨 Latest commit d3a35ff
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-sawine-19fcf1/deploys/64d689507da6b800086aed8d

2023-08-11T19:47:32.962+0100    ERROR   viridian/common.go:228  listing clusters: json: cannot unmarshal array into Go struct field Cluster.Content.allowedIps of type string

Here's an example grabbed from the Viridian UI
{id: 177, ip: "207.154.227.247", description: null}
@pmcgleenon pmcgleenon force-pushed the viridian-allowedips branch from 767d42d to d3a35ff Compare August 11, 2023 19:17
Copy link
Collaborator

@yuce yuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yuce yuce merged commit e23ad31 into main Aug 14, 2023
@yuce yuce added this to the v5.3.3 milestone Sep 11, 2023
@yuce yuce deleted the viridian-allowedips branch November 21, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants