Set "text/yaml" in index.yaml Content-Type #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denismaggior8 <[email protected]>
|
Hi @hayorov, could you please review my PR? Thanks! |
hayorov
approved these changes
Jul 31, 2021
|
Many thanks, @denismaggior8 , will be included in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm official doc states that "Make sure yaml files are served with the correct content type (text/yaml or text/x-yaml)". With this PR I made sure that newly created repos contain index.yaml file with the correct Content-Type metadata attribute (text/yaml).
Fixes issue #92
Signed-off-by: denismaggior8 [email protected]