fix: avoid GCS caching the index file #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more details on Caching can be found here https://cloud.google.com/storage/docs/gsutil/addlhelp/WorkingWithObjectMetadata#cache-control_1
rawlingsj
changed the title
|
We've been running with this for a few days now and it's working great! |
rawlingsj
added a commit
to jenkins-x-labs/helm-image
that referenced
this pull request
Mar 24, 2020
|
Is there any feedback on this PR? Would love to see it get merged as we are reliant on it now and it's been working great. In fact without this change I think users will run into issues if a helm release of a chart follows another in quick succession before the bucket cache has been updated. |
|
Looking forward for this 👍 |
erik-forsgren
approved these changes
Apr 16, 2020
rawlingsj
added a commit
to jenkins-x/jxl-base-image
that referenced
this pull request
Apr 17, 2020
|
@hayorov does it look good to you? |
|
@hayorov is it possible to merge this PR please? Without it users run into caching issues of the index.yaml. We have been using it for over a month to release well over a hundred charts and it is working great. |
|
Yay - thanks @hayorov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more details on Caching can be found here https://cloud.google.com/storage/docs/gsutil/addlhelp/WorkingWithObjectMetadata#cache-control_1
Added this PR as Work In Progress while we validate using our pipelines