Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #16 #17

Merged
merged 3 commits into from
Jun 2, 2019
Merged

Fixes #16 #17

merged 3 commits into from
Jun 2, 2019

Conversation

Klaboe
Copy link
Contributor

@Klaboe Klaboe commented Apr 9, 2019 •
edited
Loading

A fix for #16

Has expanded the case-check to include MSYS_NT in windows check.

Check generated os-variable for UNKNOWN to determine installation abort

@Klaboe
Copy link
Contributor Author

Klaboe commented Apr 23, 2019

$ megacheck ./... Megacheck has been deprecated. Please use staticcheck instead. unsupported version of go: exit status 2: flag provided but not defined: -compiled usage: list [-e] [-f format] [-json] [build flags] [packages] Run 'go help list' for details. The command "megacheck ./..." exited with 1.

Seems to be like an issue with the setup of travis?

@hayorov hayorov self-requested a review June 2, 2019 12:33
@hayorov hayorov added the bug label Jun 2, 2019
@hayorov hayorov added this to the 0.2.x milestone Jun 2, 2019
hayorov
hayorov approved these changes Jun 2, 2019
View reviewed changes
Copy link
Owner

@hayorov hayorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hayorov hayorov merged commit 0f0626e into hayorov:master Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayorov hayorov hayorov approved these changes

Assignees

@Klaboe Klaboe

Labels
bug
Projects
None yet
Milestone
0.2.x
Development

Successfully merging this pull request may close these issues.
2 participants
@Klaboe @hayorov