Allow GCS authentication with OAuth Access Token #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayorov
approved these changes
Mar 27, 2022
|
Many thanks for your contribution. Released with '0.3.20'! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running CICD on-prem often users would avoid keeping SA credentials file on CICD servers/executors due to security reasons and instead rely on auth broker like Hashicorp Vault for OAuth access token generation. GCLOUD already supports auth via access token , I'd like to contribute a change which allow the same for
helm-gcsplugin.These are not breaking changes and have been tested locally.