Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rm(remove) chart issues #103

Merged
merged 3 commits into from
Sep 21, 2021
Merged

Fix rm(remove) chart issues #103

merged 3 commits into from
Sep 21, 2021

Conversation

TejaBeta
Copy link
Contributor

Hello @hayorov 👋,
This PR will fix a current issue with rm functionality by using url from the index.yaml.

By doing so we can have two fixes,

  1. WRT to bucketPath when used
helm gcs push app001-0.0.1.tgz my-bucket --bucketPath=app001

End result

gs://my-bucket
|---index.yaml
|     |--app001\
|     |    |--app001.0.0.1.tgz

but the rm kept trying to remove from gs://my-bucket/app001.0.0.1.tgz as the object doesn't exists in the path, it throws error.

  1. Fixes this issue as well.

Thanks.

@hayorov hayorov merged commit 1c01eb2 into hayorov:master Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants