Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish with optimistic locking #1

Closed
ausov opened this issue Nov 1, 2017 · 1 comment
Closed

Publish with optimistic locking #1

ausov opened this issue Nov 1, 2017 · 1 comment

Comments

@ausov
Copy link

ausov commented Nov 1, 2017

As user,
I want to see optimistic locking error when I try to push when my repository index is not up-to-date
So that I do not overwrite changes in repo index made by someone else at the same time.

As user,
I want to optionally to reload index and retry push when optimistic locking error occurs
So that I can push in simultaneously run automated builds.


Design concept proposal:

  • when loading index from repo, get GCS $revision on index.yaml
  • when pushing, upload index first with conditional PUT: add header x-goog-if-generation-match:$revision
  • on error, to optionally retry, reload fresh index and run push again

See example: https://github.com/ausov/helm-gs/blob/3d994597fbddae7029ee0e3afad6d45796615761/bin/publish.sh#L72

@nouney
Copy link
Contributor

nouney commented May 13, 2018

Thanks @ausov for this issue. It is fixed in version 0.2.0.

@nouney nouney closed this as completed May 13, 2018
hayorov pushed a commit that referenced this issue Dec 24, 2019
Migrate helm-gcs to be compatible with Helm3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants