Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customize ui v2 #98

Closed
wants to merge 3 commits into from
Closed

Conversation

xmaillard
Copy link
Contributor

@cvmat this is my second attempt.

I had really big problems with git here. I hope this one is the good one.

This should close #97

Keep up the good work.
Xavier

1. Add 2 customize groups
2. Transform as much as possible defvar incatations to defcustom
3. Clean up trailing whitespaces (when it applies)

That's it. It should be pretty straight and safe to install.
There is still work to do though.
@xmaillard
Copy link
Contributor Author

Any news ?

Regards

@cvmat
Copy link
Collaborator

cvmat commented Jan 11, 2015

The patch dd3cfae adds TAB to docstrings and comments.

Some whitespaces in the credits and comments describing timeline spec as S-expression, placed at the 4511-th line of dd3cfae , are replaced with a TAB. Since Emacs does not automatically indent in comments (on my env at least), I have used whitespaces in comments.

Is the above modification one of a convention? Or is it required to suppress errors from some document checking tool?

I have checked some Emacs LISP files distributed with Emacs.
In gnus.el, the docstring of the variable gnus-group-faq-directory are indented with TABs but that of the macro gnus-define-group-parameter are indented with whitespaces only.

For ease of editing, I want not to use TABs in docstrings and comments if possible.

Can I import your work with my modification?

(I will also fix the credit because twittering-mode does not include
works in the years 2012-2015 by Mr. Hayamizu.)

@xmaillard
Copy link
Contributor Author

Off course. I think my setup is misconfigured concerning the whitespace/TAB conventions. I have tried to fix as many things as I could.

You can effectively import my changes with YOUR modifications.

Regards
Xavier

@cvmat
Copy link
Collaborator

cvmat commented Feb 8, 2015

I have imported your work at a18606d (and I fixed it in 58f4e60 ) . Please check it.

@xmaillard
Copy link
Contributor Author

AFAICT, it is good.

Thank you. I will publish something smaller next time ^^

Regards

@xmaillard xmaillard closed this Feb 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants