Fusion locales only when getting String #628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had added an en.properties but somehow when I was under en_US locale
I didn't see the "translated version" which is in lower case
The reason was that only once you parsed en_US strings, it would add the "parent" strings. But my last parsed file one was as an "en" one and not an "en_US" one, so en strings were not added to en_US ones.
The solution I thought was to "fusion" en and en_US strings only in getStrings. Not only does it fix the bug but it saves space, as you don't have duplicate strings in en and en_US