Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate code #68

Closed
wants to merge 2 commits into from
Closed

Conversation

dmitryuk
Copy link

Because checking of CHANNEL extra has already exists on 424 line, it is no need to check it again on 435 line.
Finally and anyway DEFAULT_CHANNEL_ID will be used as a value if count(channels)>0.

Copy link

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot, this should not be added, pelase rever this change.

@@ -37,6 +37,8 @@ jobs:
uses: actions/[email protected]
with:
node-version: 14.x
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: 'true'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this.

@erisu erisu mentioned this pull request Feb 8, 2021
9 tasks
@erisu erisu closed this in #81 Feb 8, 2021
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants