Skip to content

Commit

Permalink
fix: incorrect initial cordova-cli requirement
Browse files Browse the repository at this point in the history
  • Loading branch information
erisu committed Nov 11, 2020
1 parent 6a71d66 commit 79333b2
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
8 changes: 4 additions & 4 deletions docs/INSTALLATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

| Plugin version | Cordova CLI | Cordova Android | Cordova iOS | CocoaPods |
| -------------- | ----------- | --------------- | ----------- | --------- |
| 1.0.0 | 9.0.0 | 8.0.0 | 5.1.1 | 1.8.0 |
| 1.0.0 | 10.0.0 | 8.0.0 | 5.1.1 | 1.8.0 |

To install from the command line:

Expand Down Expand Up @@ -117,7 +117,7 @@ To make the two work together, you need to migrate your GCM project from Google
{
"cordova": {
"plugins": {
"havesource-cordova-plugin-push": {
"@havesource/cordova-plugin-push": {
"ANDROID_SUPPORT_V13_VERSION": "28.0.0",
"FCM_VERSION": "18.+"
}
Expand Down Expand Up @@ -230,8 +230,8 @@ This plugin uses the [Firebase/Messaging](https://cocoapods.org/pods/Firebase) l
If you are attempting to install this plugin and you run into this error:

```log
Installing "havesource-cordova-plugin-push" for ios
Failed to install 'havesource-cordova-plugin-push':Error: pod: Command failed with exit code 1
Installing "@havesource/cordova-plugin-push" for ios
Failed to install '@havesource/cordova-plugin-push':Error: pod: Command failed with exit code 1
at ChildProcess.whenDone (/Users/smacdona/code/push151/platforms/ios/cordova/node_modules/cordova-common/src/superspawn.js:169:23)
at emitTwo (events.js:87:13)
at ChildProcess.emit (events.js:172:7)
Expand Down
2 changes: 1 addition & 1 deletion hooks/browser/updateManifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module.exports = function (context) {

var pluginManifestPath = path.join(
context.opts.projectRoot,
'plugins/havesource-cordova-plugin-push/src/browser/manifest.json'
'plugins/@havesource/cordova-plugin-push/src/browser/manifest.json'
);

fs.readFile(pluginManifestPath, 'utf8', function (err, pluginJson) {
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@
"engines": {
"cordovaDependencies": {
"1.0.0": {
"cordova": ">=9.0.0",
"cordova": ">=10.0.0",
"cordova-android": ">=8.0.0",
"cordova-ios": ">=5.1.1"
}
}
},
"types": "./types/index.d.ts",
"cordova": {
"id": "havesource-cordova-plugin-push",
"id": "@havesource/cordova-plugin-push",
"platforms": [
"ios",
"android",
Expand Down
4 changes: 2 additions & 2 deletions plugin.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
xmlns:android="http://schemas.android.com/apk/res/android"
id="havesource-cordova-plugin-push" version="1.0.1-dev.0">
id="@havesource/cordova-plugin-push" version="1.0.1-dev.0">

<name>Cordova Push Plugin</name>
<description>Enable receiving push notifications on Android, iOS and Windows devices. Android uses Firebase Cloud Messaging. iOS uses Apple APNS Notifications. Windows uses Microsoft WNS Notifications.</description>
Expand All @@ -13,7 +13,7 @@
</js-module>

<engines>
<engine name="cordova" version=">=9.0.0"/>
<engine name="cordova" version=">=10.0.0"/>
<engine name="cordova-android" version=">=8.0.0"/>
<engine name="cordova-ios" version=">=5.1.1"/>
</engines>
Expand Down

0 comments on commit 79333b2

Please sign in to comment.