Fake unplug devices when a root hub is deinit #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathach
force-pushed
the
unplug_on_deinit
branch
from
5e870b1 to
aa46fa7
Compare
hathach
force-pushed
the
unplug_on_deinit
branch
from
aa46fa7 to
ddb1034
Compare
hathach
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
thank you, I made a change to simply use hub_addr=0, hub_port=0, which will also remove all the downstream devices by process_removing_device()
Note: #2550 also helps to make removing an hub nicer without using event queue to unroll recursive removal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes the correct "umount" callbacks to occur before deiniting a root hub and its drivers.