Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uvc multiple interface support #2520

Merged

Conversation

lijunru-hub
Copy link
Contributor

  1. fix next interface may have IAD_DESC
  2. fix vs_itf can't be open on bulk mode.

Describe the PR
Resolved the issue where the current UVC Class could not correctly iterate through all interface numbers in the case of multiple VC interfaces and could not open each VS interface under each VC in bulk mode.

Additional context
#2513

@lijunru-hub lijunru-hub force-pushed the fix/uvc_support_multiple_interface branch from b587bcf to a17a3d2 Compare March 15, 2024 07:23
@kkitayam
Copy link
Collaborator

Thank you for your PR!

I will check the PR on my environment. Please wait a few days.

@kkitayam
Copy link
Collaborator

In Windows 11, it was confirmed that multiple VC interfaces were correctly enumerated by applying the PR, but it failed without the PR. LGTM.

@kkitayam
Copy link
Collaborator

@hathach

Just a heads up, the pre-commit action is failing. I'm not sure if we should go ahead with the merge. Could you check it out when you get a chance?

@kkitayam
Copy link
Collaborator

I have confirmed that it is possible to capture 2 streams simultaneously using the following example.
kkitayam:add_uvc_2ch_example

1. fix next interface may have IAD_DESC
2. fix vs_itf can't be open on bulk mode.
@kkitayam
Copy link
Collaborator

@hathach

Just a heads up, the pre-commit action is failing. I'm not sure if we should go ahead with the merge. Could you check it out when you get a chance?

I've confirmed that the pre-commit has successfully run on my local WSL machine. In my estimation, I believe the reason why the GitHub action's pre-commit failed is due to the test environment. I think there are no issues with this PR.

@kkitayam kkitayam merged commit a4101c4 into hathach:master Mar 19, 2024
48 of 49 checks passed
@hathach
Copy link
Owner

hathach commented Mar 20, 2024

thank @lijunru-hub for the fix, and @kkitayam for reviewing and testing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants