Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes required for new SDK 3.2.0 #2514

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Changes required for new SDK 3.2.0 #2514

merged 3 commits into from
Apr 3, 2024

Conversation

camilaodsouza
Copy link

  • Define EP_ALLOCREQ
  • Define EP_FREEREQ
  • Define EP_ALLOCBUFFER
  • Define EP_FREEBUFFER

Those were previously defined in spresense-exported-sdk, but now have been removed.

Changes required for SDK 3.2.0:
eed3747 
 - Define EP_ALLOCREQ
 - Define EP_FREEREQ
 - Define EP_ALLOCBUFFER
 - Define EP_FREEBUFFER

Those were previously defined in spresense-exported-sdk, but now have been removed.
@camilaodsouza camilaodsouza mentioned this pull request Mar 11, 2024
Closed
hathach
hathach reviewed Mar 11, 2024
View reviewed changes
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we wrap these with #ifndef so that it can work with both sdk 3.2.0 and previous sdk version ?

Improved SDK 3.2.0 compatibility
307cce9 
- Used usbdev_allocreq for compatibility with SDK 3.2.0
- Wrapped previous code in #ifdef for legacy compatibility
hathach
hathach reviewed Apr 3, 2024
View reviewed changes
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the first changes, but just wrap it with ifndef to compatible with both version of sdk. I will make the change myself since it is quick enough.

hathach
hathach approved these changes Apr 3, 2024
View reviewed changes
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, I added check if usbdev_allocreq failed, and add note for sdk v2, v3. Will merge when ci passes

@hathach hathach merged commit 66cdf6d into hathach:master Apr 3, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hathach hathach hathach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camilaodsouza @hathach