[host] abort all pending transfer when SET_CONFIGURATION is complete #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NFIGURATION is successful - usbh: abort all pending xfer when SET_CONFIGURATION is complete - use tu_edpt_release in tuh_edpt_abort_xfer instead of usbh_edpt_release - rename _xfer_complete -> _control_xfer_complete
hathach
commented
Mar 4, 2024
| case CONTROL_STAGE_ACK: | ||
| _xfer_complete(dev_addr, result); | ||
| break; | ||
| case CONTROL_STAGE_ACK: { |
There was a problem hiding this comment.
abort all pending transfer when SET_CONFIGURATION is complete
hathach
commented
Mar 4, 2024
| @@ -741,7 +743,7 @@ bool tuh_edpt_abort_xfer(uint8_t daddr, uint8_t ep_addr) { | |||
| TU_VERIFY(hcd_edpt_abort_xfer(dev->rhport, daddr, ep_addr)); | |||
| // mark as ready and release endpoint if transfer is aborted | |||
| dev->ep_status[epnum][dir].busy = false; | |||
| usbh_edpt_release(daddr, ep_addr); | |||
| tu_edpt_release(&dev->ep_status[epnum][dir], _usbh_mutex); | |||
There was a problem hiding this comment.
tu_edpt_release() is lighter version
hathach
commented
Mar 4, 2024
|
|
||
| dev->configured = 1; | ||
|
|
||
| // Parse configuration & set up drivers | ||
| // driver_open() must not make any usb transfer | ||
| TU_ASSERT(_parse_configuration_descriptor(daddr, (tusb_desc_configuration_t*) _usbh_ctrl_buf),); |
There was a problem hiding this comment.
move _parse_configuration_descriptor() from pre to post SET_CONNFIGURATION
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
fix an issue with circuitpython adafruit/circuitpython#8885