Log outbound xfer bytes while in debug #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is helpful but too verbose, it could introduce other timing issues. Especially with bulk transfer like msc class. We should increase the log level to at least 3 for this info. |
antoniovazquezblanco
force-pushed
the
debug
branch
from
9dafea5 to
98bb01f
Compare
|
Done! :D |
hathach
requested changes
Feb 6, 2024
antoniovazquezblanco
force-pushed
the
debug
branch
from
98bb01f to
0531027
Compare
|
Made the requested changes. Also improved a bit on the previous solution. Thank you for being so patient with this minuscule PR. it is helping me learn more about the project! |
hathach
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This simple PR logs outbound xfer bytes when log level is set to debug. It is useful to be able to dissect the full conversation and not only incoming packets.
While this may be too verbose, it is quite useful when things go south.
Additional context
This is really nice in combination with a simple USB dissector. I am currently using scapy to parse the logs. I may create a PR to scapy with the relevant USB layers and may post an example on how to use them in a future PR.