Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests to work with the new setup. #1

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Fix tests to work with the new setup. #1

merged 1 commit into from
Aug 2, 2024

Conversation

bzbarsky-apple
Copy link

Specific changes:

  • Enable SetActivePresetRequest command in all-clusters-app.
  • Fix assignment of a PresetStructWithOwnedMembers to another PresetStructWithOwnedMembers to actually work correctly.
  • Move constraint checks that happen on write from commit to write.
  • Fix sending of atomic responses to not have use-stack-after-return.
  • Fix PICS for the tests involved.

@bzbarsky-apple
Fix tests to work with the new setup.
23f3063 
Specific changes:

* Enable SetActivePresetRequest command in all-clusters-app.
* Fix assignment of a PresetStructWithOwnedMembers to another
  PresetStructWithOwnedMembers to actually work correctly.
* Move constraint checks that happen on write from commit to write.
* Fix sending of atomic responses to not have use-stack-after-return.
* Fix PICS for the tests involved.
@hasty hasty merged commit ed59a01 into hasty:add_presets_to_Sdk Aug 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivi-apple nivi-apple nivi-apple approved these changes

Assignees
No one assigned
Labels
app examples tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @nivi-apple @hasty