Add requirements for Open edX Redwood #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fghaas
reviewed
Jul 29, 2024
|
Yep that makes sense, let's see if I added it correctly. |
Almost. :) You still need to add 3.11 to the build matrix in |
fghaas
reviewed
Aug 1, 2024
tox.ini
Outdated
Comment on lines
6
to
7
| 3.8: py38-lilac,py38-maple,py38-nutmeg,py38-olive,py38-palm,py38-quince,py38-redwood,flake8 | ||
| 3.11: py311-lilac,py311-maple,py311-nutmeg,py311-olive,py311-palm,py311-quince,py311-redwood,flake8 |
There was a problem hiding this comment.
I'd argue that this ought to be sufficient:
Suggested change
| 3.8: py38-lilac,py38-maple,py38-nutmeg,py38-olive,py38-palm,py38-quince,py38-redwood,flake8 | |
| 3.11: py311-lilac,py311-maple,py311-nutmeg,py311-olive,py311-palm,py311-quince,py311-redwood,flake8 | |
| 3.8: py38-lilac,py38-maple,py38-nutmeg,py38-olive,py38-palm,py38-quince,flake8 | |
| 3.11: py311-redwood,flake8 |
tox.ini
Outdated
| @@ -1,9 +1,10 @@ | |||
| [tox] | |||
| envlist = py38-{lilac,maple,nutmeg,olive,palm,quince},flake8,report | |||
| envlist = py{38,311}-{lilac,maple,nutmeg,olive,palm,quince,redwood},flake8,report | |||
There was a problem hiding this comment.
... and we could possibly reduce the matrix here, too.
Suggested change
| envlist = py{38,311}-{lilac,maple,nutmeg,olive,palm,quince,redwood},flake8,report | |
| envlist = py38-{lilac,maple,nutmeg,olive,palm,quince},py311-redwood,flake8,report |
fghaas
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.