Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make accepting subnet routes optional #252

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

willnorris
Copy link
Contributor

This is needed in some scenarios, such as when the other node is advertising the subnet that home assistant is on.

@lmagyar
Copy link
Contributor

lmagyar commented Sep 6, 2023

Just a note (I'm only a plain user of this add-on, and a maintainer of a fork of it): users still can misconfigure their setup, and that can "soft brick" their HA device, and then they are unable to disable "accepting subnet routes". (And first they have to understand what caused the "soft bricking" in the first place.)

So there is PR #201 that is a hacky workaround to prevent the "soft bricking", and that emits some information about the situation into the log. Though that prevents this add-on to be used for load balancing and failover.

To be honest, I don't know what is a good solution for this situation. I think:

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Oct 7, 2023
@lmagyar
Copy link
Contributor

lmagyar commented Oct 7, 2023

not stale

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Oct 8, 2023
@frenck frenck added the new-feature New features or options. label Oct 15, 2023
This is needed in some scenarios, such as when the other node is
advertising the subnet that home assistant is on.
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @willnorris 👍

../Frenck

@frenck frenck merged commit 3285675 into hassio-addons:main Oct 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants