-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request TLS certificate for Tailnet name #134
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've renamed the config option (again), from |
Closed
I'm closing this PR in favor of #137, because that provides more functionality with no configuration. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces PR #89
Fixes #62
PR #130, #131, #132 and #133 precedes this PR
Update: PR #137 I think is a better solution to the #62 issue, because #137 doesn't need any manual configuration and also provides a built-in proxy for the https traffic (we don't need to refresh the certificates, this is all done by tailscale automatically).
Proposed Changes
Request TLS certificate for Tailnet name
This is based on #89, but
certificate_tailnet_name
(notdomain_alias
), it is more logical, it is analog to thetailscale cert <machine-name>.<tailnet-name>.ts.net
command/ssl/tailscale
directory before fetching the cert--statedir=/data
instead of--state=/data/tailscaled.state
, see Tailscale.sh: use --statedir instead of --state tailscale/tailscale-qpkg#64