Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track consumed token count in ParserState (and ParseError) #175

Open
phadej opened this issue Sep 11, 2023 · 0 comments
Open

Track consumed token count in ParserState (and ParseError) #175

phadej opened this issue Sep 11, 2023 · 0 comments
Labels
pvp:major

Comments

@phadej
Copy link
Collaborator

phadej commented Sep 11, 2023

Relying on (user settable) SourcePos for deciding which parse is longer (in mergeError) is unreliable.

FWIW megaparsec tracks the count.

The #96 is different, as it adds character count to SourcePos. Yet, both changes are breaking ones, as ErrorPos "constructors" are part of public interface.
@phadej phadej mentioned this issue Sep 11, 2023
Closed
phadej added a commit that referenced this issue Sep 11, 2023
@phadej
Resolve #171.
b22f9c5 
Don't compare source names when deciding "longer match"
in mergeError. #175 would be a better fix, but that would require
a major bump.
@phadej phadej mentioned this issue Sep 11, 2023
Merged
phadej added a commit that referenced this issue Sep 11, 2023
@phadej
Resolve #171.
73dace7 
Don't compare source names when deciding "longer match"
in mergeError. #175 would be a better fix, but that would require
a major bump.
phadej added a commit that referenced this issue Sep 11, 2023
@phadej
Resolve #171.
406f858 
Don't compare source names when deciding "longer match"
in mergeError. #175 would be a better fix, but that would require
a major bump.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pvp:major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phadej