Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move 8.8.4 and 8.6.5 to the old-ghcs run #9947

Closed
wants to merge 1 commit into from

Conversation

geekosaur
Copy link
Collaborator

Github has moved macos-latest to macos-14 on ARM, so those jobs can't find a working ghc (ARM support started in 8.10.5). The alternative is to split the main validate run in half so that 8.6 and 8.4 can be run on macos-13 instead of macos-latest.

Template Β: This PR does not modify cabal behaviour (documentation, tests, refactoring, etc.)

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Github has moved `macos-latest` to `macos-14` on ARM, so those jobs
can't find a working `ghc` (ARM support started in 8.10.5). The
alternative is to split the main validate run in half so that
8.6 and 8.4 can be run on `macos-13` instead of `macos-latest`.
@geekosaur
Copy link
Collaborator Author

geekosaur commented Apr 28, 2024

Does anyone know why there's a bootstrap job on OS X? I thought generating the bootstrap plans didn't need to be done on multiple OSes.

The reason I ask is that apparently the macos-14 runner doesn't have ghcup preinstalled, so something will need to be done there to install it.

ETA: it's also missing LLVM.

geekosaur added a commit to geekosaur/cabal that referenced this pull request Apr 28, 2024
haskell#9947 is the long term
solution, but it seems `macos-14` is missing both ghcup and LLVM.
This switches us back to `macos-13` for now so CI works.
@ulysses4ever
Copy link
Collaborator

I didn't think it's the right approach to move the 8.8 or 8.6 anywhere, as it is done here, because they're in our support window. I think it should be done though include/exclude as in #9949

@geekosaur geekosaur closed this Apr 28, 2024
@geekosaur geekosaur deleted the macos-intel-runners branch April 28, 2024 18:02
@Mikolaj
Copy link
Member

Mikolaj commented Apr 29, 2024

@geekosaur

Does anyone know why there's a bootstrap job on OS X? I thought generating the bootstrap plans didn't need to be done on multiple OSes.

I think CI tests the actual bootstrapping (building using the bootstrap plans). I don't think we have a CI job that tests boostrap plan generation, which is a pity (we discover PRs that break it too late).

@ulysses4ever

I didn't think it's the right approach to move the 8.8 or 8.6 anywhere, as it is done here, because they're in our support window.

I know what you mean, but formally, the window means we should not exclude nor break the GHCs in cabal, not in CI. As I've mentioned on the channel repeatedly in the last week, when discussion the unbearable slowness of OSX CI jobs and the upcoming macos-14 breakage, we should consider removing some OSX CI jobs unless macos-14 can run them and speeds them up enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants