Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #9944

Merged
merged 1 commit into from
May 1, 2024
Merged

Update PR template #9944

merged 1 commit into from
May 1, 2024

Conversation

ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Apr 27, 2024

Stress an API change is enough to warrant a changelog.d entry. Check #9856 to see why we need it.

Suggestions on how to improve the text welcome.


Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions). n/a

@ffaf1 ffaf1 added attention: needs-review re: devx Improving the cabal developer experience (internal issue) labels Apr 27, 2024
@ffaf1 ffaf1 force-pushed the pr-template branch 3 times, most recently from 9735414 to 6eba54c Compare April 27, 2024 17:58
@ffaf1
Copy link
Collaborator Author

ffaf1 commented Apr 28, 2024

Updated to take advantage of #9946.

@ffaf1 ffaf1 added the merge me Tell Mergify Bot to merge label Apr 28, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Apr 30, 2024
@Mikolaj
Copy link
Member

Mikolaj commented May 1, 2024

@mergify rebase

Stress an API change is enough to warrant a `changelog.d` entry.
Check haskell#9856 to see why we need it.
Copy link
Contributor

mergify bot commented May 1, 2024

rebase

✅ Branch has been successfully rebased

@mergify mergify bot merged commit 41c140a into haskell:master May 1, 2024
49 checks passed
@Mikolaj
Copy link
Member

Mikolaj commented May 1, 2024

I don't think we need to backport this. Thank you, guys!

@ffaf1 ffaf1 deleted the pr-template branch May 1, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge re: devx Improving the cabal developer experience (internal issue)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants