Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some debugging to CmdRun/Terminate test #8417

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

robx
Copy link
Collaborator

@robx robx commented Aug 22, 2022

Compare #8416. This adds timestamped debug output, so that next time it fails we can tell a bit better what went wrong.

@robx

This comment was marked as resolved.

@robx

This comment was marked as resolved.

@robx robx marked this pull request as ready for review August 22, 2022 16:10
@robx robx force-pushed the debug-kill-test branch from 65b188f to 4603acd Compare August 22, 2022 16:10
@robx robx added the merge me Tell Mergify Bot to merge label Aug 22, 2022
robx added 2 commits August 24, 2022 21:23
This makes the `finally` apply to the last `do` block as intended.
No real effect on the test, though.
We've seen some instability in the test, compare

  haskell#8416

This adds timestamped output to make it easier to
see what goes wrong in case the test fails again.
@mergify mergify bot merged commit ef8e495 into haskell:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-review merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants