Add autogen-includes field #6037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pro-tip: you can now use the Draft PR feature instead of this. |
|
Are CI performed on draft PRs? https://github.blog/2019-02-14-introducing-draft-pull-requests/ doesn't mention, |
|
Yes they are.
Excerpts from Oleg Grenrus's message of 2019-05-07 14:38:17 +0000:
… Are CI performed on draft PRs? https://github.blog/2019-02-14-introducing-draft-pull-requests/ doesn't mention,
|
phadej
force-pushed
the
autogen-includes
branch
2 times, most recently
from
8800ec5 to
4dd2c29
Compare
phadej
force-pushed
the
autogen-includes
branch
2 times, most recently
from
25c7b63 to
428279b
Compare
|
Ready for review |
hvr
approved these changes
May 7, 2019
phadej
force-pushed
the
autogen-includes
branch
2 times, most recently
from
8f31086 to
400a936
Compare
autogen-includes aren't searched nor packages by `sdist`. This is relatively small code patch, but there are - change in file-format - short documentation of the field - `cabal check` - test-suite noise due new field in `BuildInfo`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5223
Doesn't #5169
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!