cabal check improvements for globs #5403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasicomputational
force-pushed
the
glob-missing-directory-error
branch
from
e673f1b to
a20ab93
Compare
|
This PR actually needs correction on two counts:
|
quasicomputational
force-pushed
the
glob-missing-directory-error
branch
from
a20ab93 to
061073b
Compare
|
I've fixed the two problems above. I think it'd still make sense to bump up the 'glob matches nothing' and the 'glob failed to parse' warnings to |
4 tasks
quasicomputational
force-pushed
the
glob-missing-directory-error
branch
from
a1aa7bc to
593b670
Compare
This also significantly improves the error when trying to refer to missing directories, hopefully making it clear that it's coming from Cabal. haskell#5318 and snowleopard/hadrian#634 are two bugs which manifested as Cabal trying to glob in a non-existent directory and both took some debugging because of the obscurity of the error.
These globs make `haddock`, `sdist` and `install` die, so they definitely ought to be warned about! Because of the dying behaviour, I made the checks dist-inexcusable; starting from a clean slate I would probably have only made them suspicious, but this isn't terrible.
This has been a problem since haskell#5372 began expanding globs in `cabal check`. Now the logic of running a glob is separated from the parsing, giving the caller the opportunity to handle parsing failures flexibly.
quasicomputational
force-pushed
the
glob-missing-directory-error
branch
from
593b670 to
24c4e77
Compare
|
Tested this a bit and read the code. LGTM. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!
Tests added!
This PR is based on top of #5401 and #5402 (which explains today's PR frenzy: I didn't expect to need to do #5401 when I started!). I'll rebase on master once those two are merged. As noted in #5401, the
cabal-versioncheck inCheck.hsis kind of weird; I have left it in the expected output of the relevant test on the basis that it's easy to remove later.