Allow empty set of input modules. #4891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angerman
force-pushed
the
feature/c-only-main
branch
from
892a659 to
60f1f64
Compare
23Skidoo
reviewed
Nov 16, 2017
| Configuring my-0.1... | ||
| # Setup build | ||
| Preprocessing executable 'foo' for my-0.1.. | ||
| Building executable 'foo' for my-0.1.. |
There was a problem hiding this comment.
Shouldn't we also test that it correctly outputs "hello, world"?
| -- Do not try to build anything if there are no input files. | ||
| -- This can happen if the cabal file ends up with only cSrcs | ||
| -- but no Haskell modules. | ||
| unless ((null inputFiles && null inputModules) |
There was a problem hiding this comment.
I'd maybe add an additional check, something along these lines:
let noHaskellSources = null inputFiles && null inputModules
noForeignSources = null cSrcs && null cxxSrcs && null asmSrcs && ...
when (noHaskellSources && noForeignSources) $
die "Component has no source files to compile"
Though perhaps that should be part of cabal check.
BTW, do we allow a .cpp/.asm/.cmm main-is?
| -- This can happen if the cabal file ends up with only cSrcs | ||
| -- but no Haskell modules. | ||
| unless ((null inputFiles && null inputModules) | ||
| || gbuildIsRepl bm) $ |
There was a problem hiding this comment.
What happens if you run repl on a component that only has C sources? Also, are C-only libraries allowed now?
|
@23Skidoo thanks. I'll have a look! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!
Do not try to call GHC on an empty set of
inputModules.Fixes #4890