unflip {mkNixDoc, nvSet{,'}}; refactors #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-Latukha
force-pushed
the
2021-03-08-upd-value
branch
from
a960809 to
b7acde7
Compare
Anton-Latukha
force-pushed
the
2021-03-08-upd-value
branch
from
a2c7782 to
2bd9a15
Compare
Anton-Latukha
force-pushed
the
2021-03-08-upd-value
branch
from
2bd9a15 to
2c3caf4
Compare
Anton-Latukha
changed the title
`empty = Empty = mempty`, mempty is inlined
`empty = {Tip,Tip} = mempty`: empty is inlined
Allows to observe specialization of functions.
From my test, ~ a quarter of savings.
layus
reviewed
Mar 9, 2021
Foreign module functions which are text literals... Lets stop spawning a String to serialize it into Text, which then serializes into String that serializes then into Doc. If I would compute O to it - it would explain the snails speed.
|
hahah, wtf is this: annotateLocation :: Parser a -> Parser (Ann SrcSpan a)
-annotateLocation p = do
- begin <- getSourcePos
- res <- p
- end <- get -- The state set before the last whitespace
- pure $ Ann (SrcSpan begin end) res
+annotateLocation p =
+ do
+ begin <- getSourcePos
+ end <- get -- The state set before the last whitespace
+
+ Ann (SrcSpan begin end) <$> pThis completely breaks location annotations! Guess that's my fault for not having any tests for them! |
|
The continuation is in #936. Indeed was guilty of it. |
|
Thanks for releasing so promptly!
…On Sun, 23 May 2021, 4:29 am Anton Latukha, ***@***.***> wrote:
The continuation is in #936 <#936>
.
Indeed was guilty of it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#878 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGRJXCCIOOZAPGWY5EDATLTPAHYZANCNFSM4YZUPKOA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.