default.nix: clean-up old overrides #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm compiling with 8.6.5 (>= 8.6.3) - it no longer needs explicit contravatiant. M default.nix
M default.nix
GHC844 does not work from HNix 0.5, so there bigger issues M default.nix
Anton-Latukha
added
the
refactoring
6 tasks
Closed
sorki
reviewed
May 25, 2020
sorki
approved these changes
May 25, 2020
Closed
Anton-Latukha
added a commit
that referenced
this pull request
Jul 31, 2020
default.nix: clean-up old overrides
Anton-Latukha
added a commit
that referenced
this pull request
Aug 14, 2020
default.nix: clean-up old overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report: #566
I'm compiling with 8.6.5 (in explanations that was for >= 8.6.3) - so
{aeson,base-compat-batteries}packages no longer needs explicit contravariant.Upstream type issues of
Diffmay be long solved already. So lets properly check Diff. 8.4.4 does not compile from HNix0.5and Diff is definitely not a cause of those.All other no longer needed overrides. They were not documented why they were introduced, so it is impossible to check their reasons. Freed HNix from those overrides. So we always can reintroduce them with proper documentation.
All tests pass fine.