Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accommodate with store's new addToStore API #1077

Merged
merged 3 commits into from
Aug 22, 2022

Conversation

soulomoon
Copy link
Collaborator

@soulomoon soulomoon commented Aug 20, 2022

bump up hnix-store-remote and hnix-store-core to 0.7.0
Api change due to haskell-nix/hnix-store#177
It also serves as base point to #1051

@soulomoon
Copy link
Collaborator Author

It should fix #1076

@soulomoon
Copy link
Collaborator Author

I don't know why Optional checks failed. Maybe some one could help to review it

@sjakobi
Copy link
Member

sjakobi commented Aug 20, 2022

I don't know why Optional checks failed.

It seems that the failing jobs are based on the nixos-unstable channel which currently contains hnix-store-core-0.5.0.0 and hnix-store-remote-0.5.0.0.

nix_path: nixpkgs=channel:nixos-unstable

nix_path: nixpkgs=channel:nixos-unstable

(Note that the job named Default Nixpkgs GHC (8.10), strict quality build, SDist, Optimizations, Benchmark, Haddock, Completions actually uses GHC-9.0.2!)

IMHO ignored CI failures have a bad signal-to-noise ratio, and I wouldn't mind if they would be removed.

@soulomoon
Copy link
Collaborator Author

soulomoon commented Aug 21, 2022

Thanks for the help @sjakobi
I am able to work it out now.
It seems the build script specifies the pkgs version separately.
And in the current rev for pkgs, hnix-store is not up to date.
Bumped up rev for pkgs, everything works again now.
Also I add ghc version to githubflow script to make 8.10 stays in ghc8107

@soulomoon soulomoon merged commit 6413bbc into haskell-nix:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants