Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load Entity into Block functionality #480
Load Entity into Block functionality #480
Changes from 41 commits
31410b2
0adb1d5
d9d58b0
0c98bbf
975d632
3d43a20
145aee2
54e54d7
6c584dc
1ef9b4b
0749e29
d3dd7e7
93f7550
c9c389a
8eb9592
d9513cf
9aca93b
48614a7
3d115ff
5f08195
7d78bd1
dadc0d3
85496d2
1d42631
005a503
ddaacab
d2cccb1
d67d1f3
4b10782
7aa9a5e
f947b97
30ed083
30555bc
c1991f6
0922ad9
416001b
a685464
191cac3
c4ed9f6
8ba064a
650ae59
1f0bc14
9f75c83
c6a9055
43d4501
f0d37d3
c867f5c
6ce3d8e
a6d09c6
22f7792
99f1d29
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref
here could be a function in which case your attempt to access it in your effect breaks. I would use a tool to combine refs instead. https://github.com/gregberge/react-merge-refsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. Didn't consider that. Added a todo comment in 191cac3 to handle that when working on nested menus