Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEN-53: Upgrade error-stack toolchain and use Error::provide #2912

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

TimDiekmann
Copy link
Member

@TimDiekmann TimDiekmann commented Aug 15, 2023

🌟 What is the purpose of this PR?

The Error::provide API has changed. To avoid conflicts with the recent Rust toolchain and maintain compatibility we need to update the toolchain. This reverts #2906 (GEN-52).

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • modifies a Cargo-publishable library, but it is not yet ready to publish

📜 Does this require a change to the docs?

The changes in this PR:

  • require changes to docs which are made as part of this PR

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

@TimDiekmann TimDiekmann requested a review from a team as a code owner August 15, 2023 18:23
@github-actions github-actions bot added area/infra Relates to version control, CI, CD or IaC (area) area/libs > error-stack Affects the `error-stack` crate (library) area/libs Relates to first-party libraries/crates/packages (area) area/tests New or updated tests labels Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #2912 (17169b8) into main (49b13be) will decrease coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is 83.78%.

@@            Coverage Diff             @@
##             main    #2912      +/-   ##
==========================================
- Coverage   51.90%   51.90%   -0.01%     
==========================================
  Files         337      337              
  Lines       29102    29113      +11     
  Branches      435      435              
==========================================
+ Hits        15105    15110       +5     
- Misses      13995    14001       +6     
  Partials        2        2              
Flag Coverage Δ
antsi 0.00% <ø> (ø)
deer 65.83% <ø> (ø)
error-stack 80.35% <83.78%> (-0.20%) ⬇️
hash-graph 54.80% <ø> (ø)
hash-status 0.00% <ø> (ø)
sarif 98.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
libs/error-stack/src/fmt.rs 96.37% <ø> (ø)
libs/error-stack/src/hook.rs 100.00% <ø> (ø)
libs/error-stack/src/lib.rs 33.33% <ø> (ø)
libs/error-stack/src/frame/frame_impl.rs 85.71% <73.91%> (-4.03%) ⬇️
libs/error-stack/src/context.rs 100.00% <100.00%> (ø)
libs/error-stack/src/error.rs 83.33% <100.00%> (+2.08%) ⬆️
libs/error-stack/src/frame.rs 75.00% <100.00%> (ø)
libs/error-stack/src/report.rs 85.22% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

hashdotai
hashdotai previously approved these changes Aug 15, 2023
@TimDiekmann TimDiekmann changed the title Upgrade error-stack toolchain and use Error::provide GEN-53: Upgrade error-stack toolchain and use Error::provide Aug 15, 2023
@linear
Copy link

linear bot commented Aug 15, 2023

GEN-53

indietyp
indietyp previously approved these changes Aug 15, 2023
Copy link
Member

@indietyp indietyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even tho our bot overlords have blessed this PR here you go. Overall I dislike that the provide API has been removed, but o well 🤷 it's a nightly API after all.

@TimDiekmann TimDiekmann added this pull request to the merge queue Aug 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 15, 2023
@TimDiekmann TimDiekmann dismissed stale reviews from indietyp and hashdotai via 17169b8 August 15, 2023 22:00
@TimDiekmann TimDiekmann requested a review from indietyp August 15, 2023 22:01
@TimDiekmann TimDiekmann enabled auto-merge August 15, 2023 22:01
@TimDiekmann TimDiekmann added this pull request to the merge queue Aug 16, 2023
Merged via the queue into main with commit 5a89b50 Aug 16, 2023
@TimDiekmann TimDiekmann deleted the td/gen-53-update-to-latest-errorprovide-version branch August 16, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Relates to version control, CI, CD or IaC (area) area/libs > error-stack Affects the `error-stack` crate (library) area/libs Relates to first-party libraries/crates/packages (area) area/tests New or updated tests
Development

Successfully merging this pull request may close these issues.

3 participants