-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEN-53: Upgrade error-stack
toolchain and use Error::provide
#2912
GEN-53: Upgrade error-stack
toolchain and use Error::provide
#2912
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2912 +/- ##
==========================================
- Coverage 51.90% 51.90% -0.01%
==========================================
Files 337 337
Lines 29102 29113 +11
Branches 435 435
==========================================
+ Hits 15105 15110 +5
- Misses 13995 14001 +6
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
error-stack
toolchain and use Error::provide
error-stack
toolchain and use Error::provide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even tho our bot overlords have blessed this PR here you go. Overall I dislike that the provide API has been removed, but o well 🤷 it's a nightly API after all.
🌟 What is the purpose of this PR?
The Error::provide API has changed. To avoid conflicts with the recent Rust toolchain and maintain compatibility we need to update the toolchain. This reverts #2906 (GEN-52).
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR: