Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create spec to demonstrate that superclasses are not affected by coercions #288

Conversation

martinstreicher
Copy link
Contributor

This is an additional spec to show that the fix at #282 works. This spec is perhaps a little more readable, in the sense that it shows a typical case where the bug occurs. This spec reflects what was occurring in my code almost exactly.

@@ -178,7 +178,7 @@ def value_coercion(value)
def inherited(klass)
super

klass.key_coercions = key_coercions
klass.key_coercions = key_coercions.dup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is a fix around superclass pollution, this definitely needs a CHANGELOG entry please.

@dblock dblock mentioned this pull request Mar 31, 2015
@dblock
Copy link
Member

dblock commented Mar 31, 2015

Merged via 8998021, thank you.

@dblock dblock closed this Mar 31, 2015
dblock pushed a commit that referenced this pull request Mar 31, 2015
@dblock
Copy link
Member

dblock commented Mar 31, 2015

Fyi, I cut 3.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants