Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable_mlock env support #9931

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Add disable_mlock env support #9931

merged 1 commit into from
Sep 11, 2020

Conversation

jasonodonnell
Copy link
Contributor

This adds environment variable support for setting disable_mlock. Having environment variable support is useful for Kubernetes where Kubelet requires swap to be disabled, so mlock isn't explicitly needed. We can set this environment variable on the Vault pod and have one less setting in the config.

IDE removed an extra newline as well.

Copy link
Contributor

@raskchanky raskchanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@briankassouf briankassouf added this to the 1.6 milestone Sep 11, 2020
@jasonodonnell jasonodonnell merged commit 54d0ad7 into master Sep 11, 2020
@jasonodonnell jasonodonnell deleted the disable_mlock_env branch September 11, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants