approle: Include role_name in alias metadata #9529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows people who are using templated policies to use the
role_name in their templates through {{
identity.entity.aliases.approle.metadata.role_name }}.
|
Test failure seems like a flake, but it looks like Circle doesn’t let external folks re-run tests :( |
|
@calvn As this metadata is stable (i.e. not a volatile instance_id or the like) I think it would be OK to store by default. WDYT? |
|
@kalafut Yeah that's my understanding here too :) - and seems to hold up in my test environment with this patch deployed |
|
Merging this one. The race failure does not seem to be related. |
calvn
added a commit
that referenced
this pull request
Oct 16, 2020
This change allows people who are using templated policies to use the
role_name in their templates through {{
identity.entity.aliases.approle.metadata.role_name }}.
Co-authored-by: Calvin Leung Huang <[email protected]>
calvn
added a commit
that referenced
this pull request
Oct 16, 2020
This change allows people who are using templated policies to use the
role_name in their templates through {{
identity.entity.aliases.approle.metadata.role_name }}.
Co-authored-by: Calvin Leung Huang <[email protected]>
Co-authored-by: Danielle <[email protected]>
|
@calvn thanks! 🎉 ✨ |
|
Just a small contribution for everyone who would have issues get their acls to work with the above feature. It is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows people who are using templated policies to use the role's name in their templates through
{{ identity.entity.aliases.approle.metadata.role_name }}.I'm not sure if there is a better place to implement this, but it seems like the most reliable bet to ensure that it gets populated on future logins?
Closes #8128.