Backport: Add response_types_supported to OIDC configuration (#7533) #7552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OIDC Discovery standard requires the response_types_supported field to be returned in the .well-known/openid-configuration response. Also, the AWS IAM OIDC consumer won't accept Vault as an identity provider without this field. Based on examples in the OIDC Core documentation, it appears Vault supports only the `id_token` flow, and thus that is the only value that makes sense to be set in this field. See: https://openid.net/specs/openid-connect-core-1_0.html#AuthorizationExamples
kalafut
changed the title
chrishoffman
approved these changes
Oct 7, 2019
|
Can you add a link to the PR in master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of: #7533
The OIDC Discovery standard requires the response_types_supported field
to be returned in the .well-known/openid-configuration response.
Also, the AWS IAM OIDC consumer won't accept Vault as an identity
provider without this field.
Based on examples in the OIDC Core documentation, it appears Vault
supports only the
id_tokenflow, and thus that is the only value thatmakes sense to be set in this field. See:
https://openid.net/specs/openid-connect-core-1_0.html#AuthorizationExamples