Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the policies menu point to be displayed in ui #6298

Closed
wants to merge 1 commit into from
Closed

Allow the policies menu point to be displayed in ui #6298

wants to merge 1 commit into from

Conversation

pouyana
Copy link
Contributor

@pouyana pouyana commented Feb 27, 2019 •
edited
Loading

Allows the policies menu point to be displayed to the user when the user has access to the policies.

@pouyana
Allow the policy menu point to be displayed
65bb0f1 
Allows the policy menu point to be displayed to the user when the user hast access to the policies.
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 27, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@briankassouf
Copy link
Contributor

@yhyakuna Could you take a look at this?

@meirish
Copy link
Contributor

meirish commented Feb 28, 2019

This was an issue with the code in the UI - #6301 should fix it so the existing admin policy in that guide will show the policies tab.

yhyakuna
yhyakuna approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@yhyakuna yhyakuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #6301 hasn't merged, yet, this fix looks good to me. I'll have to run through and verify all policies once Vault 1.1 comes out. Thank you!

@pbernal pbernal added this to the triaged milestone Jun 12, 2020
@aphorise aphorise requested review from hashishaw and mladlow August 15, 2022 20:01
@aphorise
Copy link
Contributor

I believe this is no longer relevant and has been fixed since - @pouyana can you please confirm?

@yhyakuna your input also welcome.

@aphorise aphorise requested a review from heatherezell August 29, 2022 23:33
@aphorise
Copy link
Contributor

aphorise commented Aug 29, 2022 •
edited
Loading

Closing as issue seems already resoled on the related learn guide section as per the original intent on this PR.

Screenshot 2022-08-30 at 01 31 37

@aphorise aphorise closed this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhyakuna yhyakuna yhyakuna approved these changes

@hashishaw hashishaw Awaiting requested review from hashishaw

@mladlow mladlow Awaiting requested review from mladlow

@heatherezell heatherezell Awaiting requested review from heatherezell

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
triaged
Development

Successfully merging this pull request may close these issues.
8 participants
@pouyana @hashicorp-cla @briankassouf @meirish @aphorise @yhyakuna @pbernal @tyrannosaurus-becks