Add cassandra plugin #2632
Merged
Add cassandra plugin #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Calvin, nice to see you back! I've started review of the other pr so please do not merge this in anywhere until the other is merged into master! |
|
Glad to be back! No problem, I'll mark you and Brian as reviewers for approval whenever it's good to merge. |
| credsutil.CredentialsProducer | ||
| } | ||
|
|
||
| func New() *Cassandra { |
There was a problem hiding this comment.
The function definition changed slightly last week, checkout the other plugins but I think this should be New() (interface{}, error)
jefferai
previously approved these changes
Apr 27, 2017
jefferai
reviewed
Apr 27, 2017
| return nil | ||
| } | ||
|
|
||
| func (c *Cassandra) RevokeUser(statements dbplugin.Statements, username string) error { |
There was a problem hiding this comment.
This function totally ignores any revocation statements set by the admin.
|
Do you want those changes applied here, or post-merge? |
|
Either way -- if you want to merge it, can you add a comment to that code post-merge so that we can make sure it gets tracked? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.