Backport of treat logical.ErrRelativePath as 400 instead of 500 into release/1.9.x #14778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #14328 to be assessed for backporting due to the inclusion of the label backport/1.9.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
The userpass auth backend may return a
500 Internal Server Error
to attempts to read or write usernames that contain..
. The underlying cause is a check performed inStorageView. SanityCheck
. It is theoretically possible for other endpoints to result in a 500 response for a path that contains..
. The policies endpoints, for examplesys/policies/acl/:path
, have their own error handling which results in returning a 400 for various errors:The proposed fix is to treat
logical.ErrRelativePath
as a 400. Rather than do this directly within the userpass logic, it is done at a higher level in the request handling logic so that it has broad coverage across any backend.