Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump go to 1.16.7 #12408

Merged
merged 3 commits into from
Aug 24, 2021
Merged

bump go to 1.16.7 #12408

merged 3 commits into from
Aug 24, 2021

Conversation

raskchanky
Copy link
Contributor

No description provided.

@vercel vercel bot temporarily deployed to Preview – vault August 23, 2021 21:26 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook August 23, 2021 21:26 Inactive
@pmmukh
Copy link
Contributor

pmmukh commented Aug 23, 2021

Think the Dockerfile.ui might need to be changed also btw, stephen just noticed that on my pr

@ncabatoff ncabatoff added this to the 1.8.2 milestone Aug 24, 2021
swayne275
swayne275 reviewed Aug 24, 2021
View reviewed changes
Copy link
Contributor

@swayne275 swayne275 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to update scripts/docker/Dockerfile.ui

@vercel vercel bot temporarily deployed to Preview – vault August 24, 2021 16:18 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook August 24, 2021 16:18 Inactive
@raskchanky
Copy link
Contributor Author

@pmmukh @swayne275 Updated with that missing file. Good catch!

swayne275
swayne275 approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@swayne275 swayne275 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. i'm going to update the comment in the release procedure doc to reference this as a more recent example

@raskchanky raskchanky merged commit ceaa44b into main Aug 24, 2021
@raskchanky raskchanky deleted the go-version branch August 24, 2021 16:54
raskchanky added a commit that referenced this pull request Aug 24, 2021
@raskchanky
bump go to 1.16.7 (#12408)
411a374
@raskchanky raskchanky mentioned this pull request Aug 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmmukh pmmukh pmmukh approved these changes

@swayne275 swayne275 swayne275 approved these changes

@mladlow mladlow Awaiting requested review from mladlow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.2
Development

Successfully merging this pull request may close these issues.
4 participants
@raskchanky @pmmukh @swayne275 @ncabatoff