Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated search select component styling #11360

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Updated search select component styling #11360

merged 2 commits into from
Apr 19, 2021

Conversation

arnav28
Copy link
Contributor

@arnav28 arnav28 commented Apr 15, 2021

  • Fixed styling for better readability and access to delete action

Screen Shot 2021-04-14 at 4 50 37 PM

@arnav28 arnav28 added the ui label Apr 16, 2021
@arnav28 arnav28 added this to the 1.7.1 milestone Apr 16, 2021
@arnav28 arnav28 requested review from hashishaw and Monkeychip April 16, 2021 00:24
Monkeychip
Monkeychip approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Monkeychip
Copy link
Contributor

@arnav28 One more thing I remember after I approved, is you'll want to add a changelog. Let me know if you need help with that.

@vercel vercel bot temporarily deployed to Preview – vault-storybook April 16, 2021 17:38 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 16, 2021 17:38 Inactive
@arnav28
Copy link
Contributor Author

arnav28 commented Apr 16, 2021

Updated the PR with changelog.

@arnav28 arnav28 modified the milestones: 1.7.1, 1.8 Apr 19, 2021
arnav28 added 2 commits April 19, 2021 14:31
@arnav28
Updated search select component styling
04fbdbb 
- Fixed styling for better readability and access to delete action
@arnav28
Added changelog file
2e67370
@arnav28 arnav28 force-pushed the ui/search-select-style branch from 05d4193 to 2e67370 Compare April 19, 2021 21:32
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 19, 2021 21:32 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 19, 2021 21:32 Inactive
@arnav28 arnav28 merged commit e6b6d38 into master Apr 19, 2021
@arnav28 arnav28 deleted the ui/search-select-style branch April 19, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashishaw hashishaw hashishaw approved these changes

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@arnav28 @Monkeychip @hashishaw