Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/control groups kv #11143

Merged
merged 5 commits into from
Mar 22, 2021
Merged

UI/control groups kv #11143

merged 5 commits into from
Mar 22, 2021

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented Mar 18, 2021 •
edited
Loading

Addressing a ticket where the error message was not displaying correctly.

error

@vercel vercel bot temporarily deployed to Preview – vault March 19, 2021 18:20 Inactive
@Monkeychip Monkeychip added bug Used to indicate a potential bug ui labels Mar 19, 2021
@vercel vercel bot temporarily deployed to Preview – vault March 19, 2021 18:21 Inactive
@Monkeychip Monkeychip marked this pull request as ready for review March 19, 2021 18:21
@Monkeychip Monkeychip modified the milestone: 1.7 Mar 19, 2021
chelshaw
chelshaw suggested changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@chelshaw chelshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small changes, great work here! 💪

ui/app/components/secret-edit.js Show resolved Hide resolved
ui/app/routes/vault/cluster/access/identity/show.js Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 19, 2021 18:28 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 19, 2021 18:32 Inactive
@Monkeychip Monkeychip added this to the 1.7.1 milestone Mar 19, 2021
@Monkeychip Monkeychip merged commit 5d59c62 into master Mar 22, 2021
@Monkeychip Monkeychip deleted the ui/control-groups-kv branch March 22, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelshaw chelshaw chelshaw approved these changes

Assignees
No one assigned
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Milestone
1.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Monkeychip @chelshaw