Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for upcoming Terraform Cloud secret engine #10823

Merged
merged 7 commits into from
Feb 22, 2021
Merged

Add documentation for upcoming Terraform Cloud secret engine #10823

merged 7 commits into from
Feb 22, 2021

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Feb 2, 2021 •
edited
Loading

This is a work-in-progress PR to add documentation for the upcoming Terraform Cloud Secret engine. The documentation reflects this companion PR: hashicorp/vault-plugin-secrets-terraform#3

Prerequisites:

@vercel
Copy link

vercel bot commented Feb 2, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

vault – ./website

🔍 Inspect: https://vercel.com/hashicorp/vault/qd7qotc46
✅ Preview: https://vault-git-website-tfc-engine.hashicorp.vercel.app

vault-storybook – ./ui

🔍 Inspect: https://vercel.com/hashicorp/vault-storybook/k4tihvv6n
✅ Preview: Canceled

[Deployment for f3dbed2 canceled]

@catsby catsby mentioned this pull request Feb 4, 2021
Merged
Valarissa
Valarissa reviewed Feb 10, 2021
View reviewed changes
Copy link

@Valarissa Valarissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple of observations. Feel free to change/reply/ignore.

@vercel vercel bot temporarily deployed to Preview – vault-storybook February 10, 2021 23:35 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 10, 2021 23:37 Inactive
Valarissa
Valarissa approved these changes Feb 10, 2021
View reviewed changes
Copy link

@Valarissa Valarissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~!

@catsby catsby mentioned this pull request Feb 17, 2021
Merged
@catsby catsby marked this pull request as ready for review February 17, 2021 16:59
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 19, 2021 20:59 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 19, 2021 21:04 Inactive
@catsby catsby requested a review from tomhjp February 19, 2021 21:05
tomhjp
tomhjp approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@catsby catsby merged commit 8c8d0a0 into master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valarissa Valarissa Valarissa approved these changes

@tomhjp tomhjp tomhjp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@catsby @Valarissa @tomhjp